Add archived parameter to filter out old markets from 2020-2021#18
Open
berlinbra wants to merge 1 commit into
Open
Add archived parameter to filter out old markets from 2020-2021#18berlinbra wants to merge 1 commit into
berlinbra wants to merge 1 commit into
Conversation
- Add archived parameter to list-markets tool schema - Set archived=false by default to exclude old markets - Handle archived parameter in API requests - Update fallback minimal params to include archived=false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
archivedparameter handling that ChatGPT identified as the key fix for the outdated market listings issue.What was missing
Your
update-to-gamma-apibranch already had the Gamma API integration, but it was missing the crucialarchivedparameter that filters out old markets from 2020-2021.Changes in this PR
Added
archivedparameter to the tool schemalist-marketstool propertiesfalseto exclude archived marketsImplemented
archivedparameter handlingarchivedparameter in thelist-marketstoolarchived=falsewhen not specifiedKey code changes
Expected result
With this fix, the API should now return current markets instead of the same 5 outdated listings from 2020-2021.