Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Remix to React Router 7 #146

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Migrate from Remix to React Router 7 #146

merged 5 commits into from
Jan 16, 2025

Conversation

benvinegar
Copy link
Owner

I'm normally not in favor of aggressive upgrading of dependencies like this, but I do want to start exploring migrating the project back to a single Cloudflare Worker (#134), and before doing that wanted to make sure I was working from the "latest" way of doing things.

@benvinegar benvinegar force-pushed the upgrade-react-router branch from fab4ed0 to 86cf8d0 Compare January 16, 2025 19:07
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Project coverage is 87.00%. Comparing base (1c544cd) to head (364cdf4).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
packages/server/functions/collect.ts 0.00% 9 Missing ⚠️
packages/server/app/entry.client.tsx 0.00% 2 Missing ⚠️
packages/server/app/entry.server.tsx 0.00% 2 Missing ⚠️
packages/server/app/load-context.ts 0.00% 0 Missing and 1 partial ⚠️
packages/server/app/routes.ts 0.00% 0 Missing and 1 partial ⚠️
packages/server/app/routes/admin-redirect.tsx 0.00% 0 Missing and 1 partial ⚠️
packages/server/app/routes/collect.tsx 0.00% 0 Missing and 1 partial ⚠️
packages/server/functions/[[page]].ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   87.26%   87.00%   -0.27%     
==========================================
  Files          38       38              
  Lines        2426     2439      +13     
  Branches      301      302       +1     
==========================================
+ Hits         2117     2122       +5     
- Misses        301      309       +8     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit 0582fa5 into main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant