Add cursory getSitesOrderedByHits test

benvinegar · Jan 14, 2024 · 4ee518f · 4ee518f
1 parent e883210
commit 4ee518f
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/app/analytics/query.test.ts b/app/analytics/query.test.ts
@@ -190,4 +190,37 @@ describe("AnalyticsEngineAPI", () => {
             ]);
         });
     });
+
+    describe("getSitesOrderedByHits", () => {
+        test("it should return an array of [siteId, count] tuples", async () => {
+
+            // note: getSitesByHits orders by count descending in SQL; since we're mocking
+            //       the HTTP/SQL response, the mocked results are pre-sorted
+            fetch.mockResolvedValue(new Promise(resolve => {
+                resolve(createFetchResponse({
+                    data: [
+                        {
+                            siteId: "example.com",
+                            count: 130,
+                        },
+                        {
+                            siteId: "foo.com",
+                            count: 100,
+                        },
+                        {
+                            siteId: "test.dev",
+                            count: 90,
+                        }
+                    ]
+                }))
+            }));
+
+            const result = await api.getSitesOrderedByHits(7);
+            expect(result).toEqual([
+                ["example.com", 130],
+                ["foo.com", 100],
+                ["test.dev", 90],
+            ]);
+        });
+    });
 });
diff --git a/app/analytics/query.ts b/app/analytics/query.ts
@@ -290,7 +290,7 @@ export class AnalyticsEngineAPI {
         return this.getVisitorCountByColumn(siteId, 'deviceModel', sinceDays);
     }
 
-    async getSitesByHits(sinceDays: number, limit?: number): Promise<any> {
+    async getSitesOrderedByHits(sinceDays: number, limit?: number): Promise<any> {
         // defaults to 1 day if not specified
         const interval = sinceDays || 1;
         limit = limit || 10;

diff --git a/app/routes/dashboard.tsx b/app/routes/dashboard.tsx
@@ -46,7 +46,7 @@ export const loader = async ({ context, request }: LoaderFunctionArgs) => {
         interval = 7;
     }
 
-    const sitesByHits = (await analyticsEngine.getSitesByHits(interval));
+    const sitesByHits = (await analyticsEngine.getSitesOrderedByHits(interval));
 
     if (!siteId) {
         // pick first non-empty site