Fixes/variants form submit #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with search form validation, where users were permitted to launch searches with invalid form state. (Redmine 2415).
Some of the previous tricks for variants form validation do not work as well in antd > 3, this is fixed by moving validation code to a parent component and invoking manually when needed.
Also discovered and fixed this issue of uncertain age: data types are not removed from the submitted form when deleting data type tabs (when removing, e.g. the "Variants" search tab, the submitted form still has fields for variants). This can block form submission, and without giving any user feedback (because the tab is not rendered).