Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip dom IDs that do not have text. #40

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Skip dom IDs that do not have text. #40

merged 1 commit into from
Jul 18, 2020

Conversation

sjonany
Copy link
Collaborator

@sjonany sjonany commented Jul 18, 2020

For some reason readability includes these as output.

This actually fixes two issues, yay!

@sjonany
Skip dom IDs that do not have text.
89651ba 
For some reason readability includes these as output.
This was linked to issues Jul 18, 2020
Extension not working on lesswrong #39
Closed
Auto-read mode gets stuck on pictures #27
Closed
@benfrancis314
Copy link
Owner

Woohoo!

@benfrancis314 benfrancis314 self-requested a review July 18, 2020 16:53
benfrancis314
benfrancis314 approved these changes Jul 18, 2020
View reviewed changes
Copy link
Owner

@benfrancis314 benfrancis314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjonany sjonany merged commit 99e488c into master Jul 18, 2020
@sjonany sjonany deleted the sjoe_temp2 branch July 20, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfrancis314 benfrancis314 benfrancis314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension not working on lesswrong Auto-read mode gets stuck on pictures
2 participants
@sjonany @benfrancis314