Fix multiple events subscription #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veged
reviewed
Sep 11, 2017
| domNode.addEventListener(event, handler, false); | ||
| }); | ||
| } | ||
| typeof e === 'string'? |
There was a problem hiding this comment.
it's better to do this in very first lines of this function — just check if e is a string and contains spaces and do forEach of this.on (we do similar https://github.com/bem/bem-core/blob/v4/common.blocks/i-bem-dom/__events/i-bem-dom__events.js#L226)
veged
reviewed
Sep 11, 2017
| } | ||
| }.bind(this); | ||
|
|
||
| typeof e === 'string'? |
There was a problem hiding this comment.
same stuff like with on — we can make smaller diff
tadatuta
force-pushed
the
fixEvents@issues/1507
branch
3 times, most recently
from
dcd772d to
248e7cb
Compare
|
@veged ⬆️ |
veged
approved these changes
Sep 11, 2017
| @@ -52,6 +52,14 @@ var undef, | |||
| * @returns {EventManager} this | |||
| */ | |||
| on : function(e, data, fn, _fnCtx, _isOnce) { | |||
| if(typeof e === 'string' && e.indexOf(' ') > -1) { | |||
| e.split(' ').forEach(function(evnt) { | |||
tadatuta
force-pushed
the
fixEvents@issues/1507
branch
from
248e7cb to
105e5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also addresses #1526 for bem-core version without jQuery.