Repository navigation
Fix 14 bugs in /src: memory safety, UB, logic errors, thread safety - #170
Merged
Merged
Conversation
Critical: - Fix use-after-free in mupRelease by deleting outside MU_TRY/MU_CATCH High: - Add missing MU_TRY/MU_CATCH to mupDefineNameChars, mupDefineOprtChars, mupDefineInfixOprtChars to prevent exceptions crossing C ABI boundary - Make s_tmpOutBuf, mupGetVar, mupGetExprVar, mupGetConst buffers thread_local to fix data races in multi-threaded usage - Fix IsVal returning 0 for all-digit strings (npos not handled) - Fix IsHexVal returning success when no hex digits follow "0x" - Add null pointer checks for variable pointers in ParseCmdCodeShort Medium: - Fix AsciiDump bounds check to validate string buffer index, not bytecode loop index - Skip constant folding when divisor is zero instead of producing inf - Add INT_MIN / -1 overflow check in Div and Mod (undefined behavior) - Cast to unsigned before shifting in Shr/Shl to avoid UB on negatives - Check stIf/stElse non-empty before top() in Finalize to prevent crash on malformed bytecode Low: - Remove unused global variable g_nBulkSize - Fix exception safety in ParserCallback::Assign by creating new object before deleting old one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical:
High:
Medium:
Low: