-
-
Notifications
You must be signed in to change notification settings - Fork 473
docs: add signing identity examples and link to how-to guides #2627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
68602c7
docs: add signing identity examples and link to how-to guides
kshivani06 4327c6d
Add towncrier news fragment for PR #2627
kshivani06 d9d17f1
Fill in towncrier details.
freakboy3742 6d2cd33
Clean up draft documentation.
freakboy3742 1aeaf70
Correct punctuation.
freakboy3742 cdab052
Fixed a stale reference.
freakboy3742 0f87eb6
Confirm fix works.
freakboy3742 9c79199
Revert CI testing config.
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few details here for future reference:
.mdextensionmisc, not adoc. Yes, it's changing documentation; but the purpose of changenote files is to be a first draft of the release notes. A relatively minor (however valuable) addition to docs isn't something that really needs to be in the release notes of the next version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback and for the final tweaks! I've noted the point about using .misc for minor doc updates instead of .doc for future reference.