-
-
Notifications
You must be signed in to change notification settings - Fork 474
Support --debug option on Android
#2351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --debug option on Android
#2351
Conversation
dc6b3e8 to
0513eeb
Compare
0513eeb to
a38f818
Compare
a38f818 to
371409a
Compare
|
This PR is waiting for the following two patches to get merged. With these patches this PR is fully working: |
|
Does this PR need any documentation updates? I guess at least some of the 4 places that say "only supported on Windows, macOS and iOS" will need to be updated. @freakboy3742: I don't know if this was mentioned somewhere in the gigantic discussion of #2173, but at what point are we going to stop calling this "experimental"? If we can do that now, then I think we can remove those paragraphs from the |
|
One unit test is failing because of the template target version change, but the test comment says it creates an empty folder "to mock a created project", which suggests it wasn't intended to actually expand a real template. If I understand correctly, the the idea is that the unit tests shouldn't depend on the template repository at all, and the |
…debugger-support-android
I added Android to the list of supported platforms in the docs.
I fixed this by updating the target version constant in the unit tests.
Wow, I did not know about this feature with |
|
Thanks, I'll look at this next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me in both PDB and VS Code, thanks! I have a few issues with the documentation, but they're not specific to Android, so I'll put them in a separate issue (#2621).
This PR adds debugger support for Android.
This PR is based on #2173 to have a working example for it. At first #2173 should be merged, then this PR.
This requires beeware/briefcase-android-gradle-template#97
briefcase-template-repo: https://github.com/timrid/briefcase-template
briefcase-template-ref: dynamic-extract-packages
PR Checklist: