Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for empty album and handle them gracefully #5548

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add check for empty album and handle them gracefully #5548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf2c25e
Add check for empty album and handle them gracefully
arsaboo Dec 15, 2024
13c6e0d
Merge remote-tracking branch 'upstream/master' into mbsync
arsaboo Dec 15, 2024
4f40771
Formating
arsaboo Dec 15, 2024
36bfade
Merge remote-tracking branch 'upstream/master' into mbsync
arsaboo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions beetsplug/mbsync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ def albums(self, lib, query, move, pretend, write):

items = list(a.items())

if not items:
self._log.info("Skipping empty album: {0}", album_formatted)
continue

# Do we have a valid MusicBrainz album ID?
if not re.match(MBID_REGEX, a.mb_albumid):
self._log.info(
Expand Down
1 change: 1 addition & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ New features:

Bug fixes:

* Add empty album check in ``mbsync``.
* :doc:`plugins/ftintitle`: The detection of a "feat. X" part in a song title does not produce any false
positives caused by words like "and" or "with" anymore. :bug:`5441`
* :doc:`plugins/ftintitle`: The detection of a "feat. X" part now also matches such parts if they are in
Expand Down
Loading