[16.0][FIX] volunteer_attendance: various fixes#580
Open
Conversation
…ity file with record rule for company access on volunteer shift attendance status.
remytms
changed the title
remytms
requested changes
Mar 9, 2026
Collaborator
remytms
left a comment
remytms
left a comment
There was a problem hiding this comment.
One small change. Then it is ok.
| string="Company", | ||
| default=lambda self: self.env.user.company_id, | ||
| required=True, | ||
| # required=True, |
Collaborator
There was a problem hiding this comment.
Either leave required or remove but do not comment. I think here it should be removed as a False value for Company is ok.
Author
There was a problem hiding this comment.
Ah sorry, didn't remove comments yet. I'll trim it now :-)
remytms
requested changes
Mar 9, 2026
Collaborator
remytms
left a comment
remytms
left a comment
There was a problem hiding this comment.
Still one change. Sorry I should have seen it the first time.
Comment on lines
+40
to
+42
| if "attendance_status_id" in vals: | ||
| vals["attendance_date"] = fields.Datetime.now() | ||
| return super().write(vals) |
Collaborator
There was a problem hiding this comment.
Ho, this one, I didn’t catch it the first time.
write should always return and call the parent function. So write this:
Suggested change
| if "attendance_status_id" in vals: | |
| vals["attendance_date"] = fields.Datetime.now() | |
| return super().write(vals) | |
| if "attendance_status_id" in vals: | |
| vals["attendance_date"] = fields.Datetime.now() | |
| return super().write(vals) |
Author
There was a problem hiding this comment.
Oh, missed it myself. Thanks, done !
Author
|
Just fixed README so that Remy is now visible as maintainer. |
…int linked to attendance status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ity file with record rule for company access on volunteer shift attendance status.
Description
Odoo task (if applicable)
Checklist before approval