Skip to content

[16.0][FIX] validate subscription before sending mail #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mihien wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] validate subscription before sending mail #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cooperator_eater/models/subscription_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ def get_eater_vals(self, partner, share_product_id):
def validate_subscription_request(self):
self.ensure_one()

if self.partner_id:
vals = self.get_eater_vals(self.partner_id, self.share_product_id)
# settattr will change the values of the partner object without
# applying the changes in the db, so we can see if the new value of
# the field eater is valid, without the risk of changing the result of
# super().validate_subscription_request() which depends on that field
setattr(self.partner_id, "eater", vals["eater"]) # noqa: B010

invoice = super().validate_subscription_request()[0]
partner = invoice.partner_id

Expand Down