[IMP] beesdoo_shift: add name_get on task_template

[tfrancoi]

this allow to use generated task template name
and not add all info of the template directly in the name

[tfrancoi]

TODO: retarget on 12.0 once add-polln-shift is merged
Move this to beesdoo_shift

[robinkeunen]

TODO:

• will need a migration script.
• move to beesdoo_shift

[robinkeunen]

could you provide an example(s) of matched pattern for readability ?
Also, nitpicking, shouldn't you compile the pattern out of the loop?

[tfrancoi]

could you provide an example(s) of matched pattern for readability ?
Yes we are looking for the time (generated by the name get) for example 12:30-15h30

Also, nitpicking, shouldn't you compile the pattern out of the loop?
From the perf point of view the number of iteration depends on the number of token in the search term so between 1 and 4. I don't think it really matter.

[tfrancoi]

https://stackoverflow.com/questions/452104/is-it-worth-using-pythons-re-compile

[robinkeunen]

Good to know, thanks!

[robinkeunen]

We try to use more explicit names in our loops, such as for template in self: or for shift_template in self:. Don't you use that at Odoo ?

[tfrancoi]

Don't you use that at Odoo ?
There is no specific guidelines for that in odoo (you can grep for rec in self, for record in self)
Personnaly when the record come from a search it makes sense to specify the object
when they come from self, you already know in which model you are, it's less important

[codecov-commenter]

Codecov Report

Merging #302 (8cb913d) into 12.0 (fa7306c) will decrease coverage by 0.29%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             12.0     #302      +/-   ##
==========================================
- Coverage   68.53%   68.24%   -0.30%     
==========================================
  Files         107      107              
  Lines        3366     3388      +22     
  Branches      589      595       +6     
==========================================
+ Hits         2307     2312       +5     
- Misses        951      968      +17     
  Partials      108      108              

Impacted Files	Coverage Δ
polln_shift/models/planning.py	25.32% <22.72%> (-0.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7306c...8cb913d. Read the comment docs.

[polchampion]

Virg et Pol : Ne pas merger, pas voulu, à mettre dans un module séparé si on veut vraiment implémenter cette fonctionnalié

[polchampion]

Ne pas merger, pas voulu, à mettre dans un module séparé si on veut vraiment implémenter cette fonctionnalié