Skip to content

use prop-types #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

use prop-types #21

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7205d9
use prop-types
duyluonglc Oct 17, 2017
ae1bd60
use proptypes
duyluonglc Oct 18, 2017
7c26c60
use proptypes
duyluonglc Oct 18, 2017
9065429
use proptypes
duyluonglc Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
'use strict';

import React, {Component, PropTypes} from 'react';
import React, {Component} from 'react';
import PropTypes from 'prop-types';
import {
StyleSheet,
View,
Text,
Image,
Dimensions,
PixelRatio,
PanResponder
PanResponder,
ViewPropTypes,
TextStylePropTypes
} from 'react-native';

class PickerAndroidItem extends Component{
Expand All @@ -34,9 +37,9 @@ export default class PickerAndroid extends Component{

static propTypes = {
//picker's style
pickerStyle: View.propTypes.style,
pickerStyle: ViewPropTypes.style,
//picker item's style
itemStyle: Text.propTypes.style,
itemStyle: TextStylePropTypes,
//picked value changed then call this function
onValueChange: PropTypes.func,
//default to be selected value
Expand Down