Skip to content

Fix clone include #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
didoda merged 2 commits into from
Dec 3, 2024
Merged

Fix clone include #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2689559
fix: clone payload
didoda Dec 3, 2024
ea52084
tests: test clone
didoda Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/BEditaClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,18 +418,18 @@ public function restoreObjects(array $ids, string $type = 'objects'): ?array
* @param string $type Object type name
* @param string $id Source object id
* @param array $modified Object attributes to overwrite
* @param array $included Associations included: can be 'relationships' and 'translations'
* @param array $include Associations included: can be 'relationships' and 'translations'
* @param array|null $headers Custom request headers
* @return array|null Response in array format
*/
public function clone(string $type, string $id, array $modified, array $included, ?array $headers = null): ?array
public function clone(string $type, string $id, array $modified, array $include, ?array $headers = null): ?array
{
$body = json_encode([
'data' => [
'type' => $type,
'attributes' => $modified,
'meta' => [
'included' => $included,
'include' => $include,
],
],
]);
Expand Down
3 changes: 2 additions & 1 deletion tests/TestCase/BEditaClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,8 +1442,9 @@ function ($document) {
static::assertArrayHasKey('params', $relationData['data']['attributes']);

// test clone
$clone = $this->client->clone('images', $mediaId, ['title' => 'Cloned image'], ['relationships', 'translations']);
$clone = $this->client->clone('images', $mediaId, ['title' => 'Cloned image', 'status' => 'draft'], ['relationships', 'translations']);
static::assertNotEmpty($clone['data']['id']);
static::assertSame('Cloned image', $clone['data']['attributes']['title']);
static::assertSame('draft', $clone['data']['attributes']['status']);
}
}
Loading