Skip to content

Conversation

@didoda
Copy link
Member

@didoda didoda commented Oct 14, 2025

You can set "timeout" in upload configuration, if you want to customize it, default "30000" milliseconds.

Example:

// config/app_local.php
<?php

return [
    // ...
    'uploadTimeout' => 30000, // in milliseconds
    // ...
];

@didoda didoda added this to the 5.x milestone Oct 14, 2025
@didoda didoda added feature New feature or request release:minor labels Oct 14, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable timeout support for upload operations. Users can now customize the upload timeout value through configuration instead of being limited to the hardcoded 30-second default.

  • Added uploadTimeout configuration option with 30000ms default
  • Updated upload configuration to include timeout value
  • Modified axios timeout to use configurable timeout from upload config

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/View/Helper/SystemHelper.php Added defaultUploadTimeout property and included timeout in uploadConfig method
tests/TestCase/View/Helper/SystemHelperTest.php Updated test to verify timeout is included in upload configuration
resources/js/app/mixins/fetch.js Modified axios timeout to use configurable upload timeout
config/app_local.example.php Added example configuration for uploadTimeout

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@didoda didoda merged commit ce78ab5 into bedita:master Oct 27, 2025
9 checks passed
@didoda didoda deleted the feat/upload-config-timeout branch October 27, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants