Handle redirect on error when saving permissions or related items #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a bugfix.
When you save a new object with permissions or related items in the form, BEM processes data save in different steps (it's not a transaction): first it saves the object, then permissions, then related items.
Buggy behaviour: if there is an exception in "saving permissions" or "saving related items", new object is saved but the page is still "new object page".
Fixed behaviour: if there is an exception in "saving permissions" or "saving related items", new object is saved, there's a redirect to the new object page with proper flash error(s).