-
Notifications
You must be signed in to change notification settings - Fork 11
Secure api "proxy" controller #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
Coverage 99.65% 99.65%
- Complexity 1321 1339 +18
==========================================
Files 97 98 +1
Lines 5151 5252 +101
==========================================
+ Hits 5133 5234 +101
Misses 18 18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some security checks for internals
/api/{action}calls.Request on urls like
/api/*from browser will be blocked with401 Unauthorized, because/apiis supposed to be used as internal proxy from ajax calls.When no user is authenticated or user has no roles:
401 Unauthorized.When user has role
admin, skip all checks.When user has non
adminroles, this checks{action}considering allowed methods for the user: data is retrieved from BEdita api, to consider which methods are allowed per action; you can customize the "blocking" logic, with a configurationApiProxy.blocked. An example follows[ 'ApiProxy' => [ 'blocked' => [ 'objects' => ['GET', 'POST', 'PATCH', 'DELETE'], 'users' => ['GET', 'POST', 'PATCH', 'DELETE'], ], ], ],This introduces some refactor to avoid using
api/objectsandapi/users, by using specific routes, with "safe" data (no relationships, no included, etc.