Skip to content

Conversation

@didoda
Copy link
Member

@didoda didoda commented Dec 31, 2024

This fixes search from side panel with advanced filters by adjusting properly the schema and using, if available, a /:type instead of /objects?filter[type][]=:type, when there is only one related type for relation.

This fixes the form, by using proper schema; in the following example, the custom field "booking status" is an enum, and it is shown as a combo; without this fix, it is shown as an input text field.

image

@didoda didoda added bug Something isn't working release:patch labels Dec 31, 2024
@didoda didoda marked this pull request as ready for review December 31, 2024 11:09
@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (62e2b3c) to head (70415af).
Report is 30 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1212      +/-   ##
============================================
- Coverage     99.65%   99.64%   -0.01%     
+ Complexity     1326     1316      -10     
============================================
  Files            98       97       -1     
  Lines          5205     5121      -84     
============================================
- Hits           5187     5103      -84     
  Misses           18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda added this to the 5.x milestone Jan 2, 2025
@didoda didoda merged commit 6b5f4f8 into bedita:master Jan 2, 2025
9 checks passed
@didoda didoda deleted the fix/search-filter-in-relation-add-panel branch January 2, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant