Skip to content

Conversation

@didoda
Copy link
Member

@didoda didoda commented Dec 19, 2024

When an audio or a video has captions (association Captions should be activated for the Audio or Video model), subtitles can be activated in audio|video player (html5 provides track tag to handle that).

This changes the "Media" section, to show provider fields with the player.

This refactorizes the stream item data into a media-item component and provides subtitles for audio|video, when available.

An example of video file (no provider) with captions:

image

An example of remote video (provider youtube):

image

@didoda didoda added feature New feature or request release:minor labels Dec 19, 2024
@didoda didoda added this to the 5.x milestone Dec 19, 2024
@didoda didoda changed the title Subtitles in videos Subtitles in audio / video Dec 19, 2024
@didoda didoda marked this pull request as ready for review December 19, 2024 11:16
@didoda didoda changed the title Subtitles in audio / video Media provider form + Subtitles in audio / video Dec 20, 2024
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (62e2b3c) to head (3d1df79).
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1211      +/-   ##
============================================
- Coverage     99.65%   99.64%   -0.01%     
+ Complexity     1326     1314      -12     
============================================
  Files            98       97       -1     
  Lines          5205     5120      -85     
============================================
- Hits           5187     5102      -85     
  Misses           18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda merged commit b6b4522 into bedita:master Dec 27, 2024
9 checks passed
@didoda didoda deleted the feat/video-subtitles branch December 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request release:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant