Skip to content

Conversation

@didoda
Copy link
Member

@didoda didoda commented Dec 3, 2024

This introduces some breaking changes:

  • php >= 8.3 (8.3.3 on scrutinizer analysis)
  • bedita api >= 5.36.0
  • cakephp >= 4.5
  • node >= 20
  • bedita/i18n >= 5
  • bedita/webtools >= 5.0.1 (bedita/php-sdk >= 4)

and other changes (lib version update).

This uses BEditaClient->clone (with bedita/php-sdk:4): a refactor is applied and clone is done via a single API call.

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (62e2b3c) to head (37c7094).
Report is 23 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1208      +/-   ##
============================================
- Coverage     99.65%   99.64%   -0.01%     
+ Complexity     1326     1311      -15     
============================================
  Files            98       97       -1     
  Lines          5205     5113      -92     
============================================
- Hits           5187     5095      -92     
  Misses           18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda changed the title BEdita API 5 only, php >= 8.1, node 20 and 22 BEdita API 5 only, php >= 8.1 (+8.4), node >= 20 Dec 3, 2024
@didoda didoda changed the title BEdita API 5 only, php >= 8.1 (+8.4), node >= 20 BEdita API 5 only, php >= 8.1, node >= 20 Dec 3, 2024
@didoda didoda changed the title BEdita API 5 only, php >= 8.1, node >= 20 Prepare release 5: BEdita API 5 only, php >= 8.1, node >= 20 Dec 3, 2024
@didoda didoda changed the title Prepare release 5: BEdita API 5 only, php >= 8.1, node >= 20 Prepare release 5: BEdita API 5 only, php >= 8.1, node >= 20 + refactor clone Dec 3, 2024
@didoda didoda marked this pull request as ready for review December 3, 2024 13:11
@didoda didoda added dependencies Pull requests that update a dependency file refactor Code refactoring release:major labels Dec 3, 2024
@didoda didoda added this to the 5.x milestone Dec 4, 2024
@didoda didoda changed the title Prepare release 5: BEdita API 5 only, php >= 8.1, node >= 20 + refactor clone Prepare release 5: BEdita API >= 5.36.0, php >= 8.1, node >= 20 + refactor clone Dec 5, 2024
@didoda didoda changed the title Prepare release 5: BEdita API >= 5.36.0, php >= 8.1, node >= 20 + refactor clone Prepare release 5: BEdita API >= 5.36.0, php >= 8.3, node >= 20 + refactor clone Dec 5, 2024
@didoda didoda merged commit 594451c into bedita:master Dec 9, 2024
9 checks passed
@didoda didoda deleted the feat/prepare-new-major branch December 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file integration refactor Code refactoring release:major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant