Skip to content

Conversation

@didoda
Copy link
Member

@didoda didoda commented Nov 22, 2024

This introduces "captions" section for objects that have associations "captions" enabled.

image

Captions formats can be defined using Caption configuration, i.e.:

'Captions' => [
    'formats' => [
        'allowed' => ['srt', 'sub', 'webvtt'],
        'default' => 'webvtt',
    ],
],

If the config is not defined, webvtt is used.
This uses webvtt validator to validate webvtt text.

@didoda didoda added the feature New feature or request label Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (62e2b3c) to head (d15fa52).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1204   +/-   ##
=========================================
  Coverage     99.65%   99.65%           
- Complexity     1326     1330    +4     
=========================================
  Files            98       98           
  Lines          5205     5219   +14     
=========================================
+ Hits           5187     5201   +14     
  Misses           18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda added this to the 4.x milestone Nov 25, 2024
@didoda didoda marked this pull request as ready for review November 25, 2024 10:34
@didoda didoda merged commit 6c4b53a into bedita:master Dec 2, 2024
18 checks passed
@didoda didoda deleted the feat/captions branch December 2, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request release:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant