[common]: Add multi-port support for component services - #188
Merged
Conversation
Signed-off-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
rekup
marked this pull request as ready for review
August 17, 2026 09:20
wthhub
approved these changes
Aug 17, 2026
wthhub
left a comment
wthhub
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extends the common chart's Service template
templates/_service.yamlto support multiple ports on a single KubernetesService, needed for StatefulSet governing/headless services. Adds an optionalportslist percomponents.<name>.services.<name>entry (name,port,targetPort,protocol), which takes precedence over the existing singularname/port/targetPort/protocolfields when present. Also adds an optionalpublishNotReadyAddressesfield for StatefulSet governing services.Fully backwards compatible, existing single-port service configs render identically.
Which issue this PR fixes
fixes #187
Notes for Reviewer:
values.schema.jsonchanges required since theservicesschema has noadditionalProperties: falserestriction, so the new fields are already permitted.Checklist:
[chart]: Changed SomethingREADME.md.gotmplfile and executedhelm-docs