Beatzip redesigned disco - #1
Merged
Merged
Conversation
- calibration.json: clamp p99 > 1.0 to 1.0 for normalized metrics, set sample_count to 1000 - CODE_OF_CONDUCT.md: replace [INSERT CONTACT METHOD] placeholder with conduct@sentinel-ai - Cargo.toml: add rust-version = '1.85' for edition 2024 + resolver 3 compatibility Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Blocker 4a: Add line_blocked_between() to MapData for segment-clamped 3D raycasting - New method: line_blocked_between(from: Vec3, to: Vec3) - Clamps BVH ray result to segment length (not infinite ray) - Falls back to 2D wall check for entire segment if BVH misses - Fixes LOS geometry for visibility calculations Blocker 4b: Deprecate is_behind_wall() in favor of segment-aware alternatives - Marked with #[deprecated] attribute - Directs callers to line_blocked_between() or line_blocked_3d() Blocker 4c: Update LOS callsite to use segment-based checking - Replaced line_blocked_3d() with line_blocked_between() in sentinel-visibility/los.rs - is_line_blocked() now checks actual segment between observer and target - Proper 3D geometry before 2D fallback (not infinite rays) Blocker 5: Real damage calculation in DamageEvent - calculate_real_damage() handles overkill: min(dmg_health, remaining_health) - Used in damage_from_event() to cap real damage to victim's remaining HP - Prevents false positives on lethal damage validation Validation: - cargo test --workspace: 115+ tests passing, 0 failures - cargo build --release: Success, zero errors - All dependencies satisfied; unblocked for integration testing Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.