Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces several CPU performance optimizations for hot-shots, a Node.js client for StatsD, DogStatsD, and Telegraf. The changes focus on reducing redundant string operations, object allocations, and function calls in hot paths when sending metrics.
Changes:
- Pre-join global tags into a cached string to avoid repeated string concatenation and joining operations
- Optimize
overrideTagshelper with a fast path that concatenates arrays when tags don't overlap - Replace
process.hrtime()withprocess.hrtime.bigint()for simpler, more efficient timing calculations - Eliminate unnecessary
Buffer.from()conversions for TCP/STREAM protocols - Cache and reuse
Buffer.byteLengthcalculations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/transport.js | Refactored addEol to use early return and handle string inputs directly |
| lib/statsd.js | Added _globalTagStr cache for pre-joined global tags, optimized Buffer handling for TCP/STREAM, reused messageBytes variable |
| lib/statsFunctions.js | Replaced process.hrtime() array operations with process.hrtime.bigint() for simpler time delta calculations |
| lib/helpers.js | Implemented fast path in overrideTags to avoid expensive filtering when tags don't overlap, switched from plain object to Map for better performance |
| CHANGES.md | Documented the performance improvements in the changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small list (after some rechecking on things) of perf improvements to make