Open
Conversation
Owner
|
Thanks for the submission. This would need to pass all tests to be considered here- you mention it doesn't need to worry about Node versions but am noticing that Node 16 isn't working here. I do understand the version is EOL, so we could remove Node 16 but Windows is here as well. I'd also want to understand more the performance implications and see some stress testing done given how widely used uds is with this project. Likely if that was all set, we'd also want to consider this first under a feature gate before having it be the default. Let me know if you are considering all of this and want to discuss more how to figure this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I recently rewrote the unix-dgram module using napi-rs and published it as a new package: https://github.com/hrhthegreat/unix_dgram_rs
This version no longer requires node-gyp during installation—prebuilt binaries are shipped with the package—and thanks to napi-rs, it’s compatible across Node.js versions without rebuilds.
The package currently supports Node.js ≥ 18. It’s published as 0.1.0-alpha.1, but it successfully passes the full test suite from the original unix-dgram. I’ve also tested it locally with hot-shots, and all tests are passing.
Would love your feedback!