Adding support for Amazon Linux 2#178
Open
justinas-b wants to merge 2 commits intobdangit:masterfrom
justinas-b:master
Open
Adding support for Amazon Linux 2#178justinas-b wants to merge 2 commits intobdangit:masterfrom justinas-b:master
justinas-b wants to merge 2 commits intobdangit:masterfrom
justinas-b:master
Conversation
bdangit
requested changes
Apr 6, 2019
Owner
bdangit
left a comment
bdangit
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good so far. Can you check out my comment?
bdangit
requested changes
Apr 21, 2019
Owner
bdangit
left a comment
bdangit
left a comment
There was a problem hiding this comment.
One last nit. Can you please squash commits?
Owner
|
gentle reminder for @justinas-b. Can you please squash commits and then we'll be okay to merge. |
Author
|
Hi @bdangit, sorry but it seems I have lost my forked repo, so I am unable to do the squash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.