Skip to content

8349107: Remove RMI finalizers #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bchristi-git wants to merge 3 commits into from
Closed

8349107: Remove RMI finalizers #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bde950
Remove finalizer from RMI RegistryContext
bchristi-git Jan 17, 2025
e4b1d4a
Remove finalizer from RMI RegistryContext.BindingEnumeration
bchristi-git Jan 17, 2025
387aa51
Remove finalizer from RMI LogInputStream
bchristi-git Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/java.rmi/share/classes/sun/rmi/log/LogInputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,4 @@ public int available() throws IOException {
public void close() {
length = 0;
}

/**
* Closes the stream when garbage is collected.
*/
@SuppressWarnings("removal")
protected void finalize() throws IOException {
close();
}
}
13 changes: 1 addition & 12 deletions src/jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ public RegistryContext(String host, int port, Hashtable<?, ?> env)
reference = ctx.reference;
}

@SuppressWarnings("removal")
protected void finalize() {
close();
}

public Object lookup(Name name) throws NamingException {
if (name.isEmpty()) {
return (new RegistryContext(this));
Expand Down Expand Up @@ -557,11 +552,6 @@ class BindingEnumeration implements NamingEnumeration<Binding> {
nextName = 0;
}

@SuppressWarnings("removal")
protected void finalize() {
ctx.close();
}

public boolean hasMore() {
if (nextName >= names.length) {
ctx.close();
Expand Down Expand Up @@ -598,8 +588,7 @@ public Binding nextElement() {
}
}

@SuppressWarnings("deprecation")
public void close () {
finalize();
ctx.close();
}
}
Loading