Skip to content

Support for readable and writeable streams #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for readable and writeable streams #35

wants to merge 3 commits into from

Conversation

fridjon
Copy link

@fridjon fridjon commented Jan 13, 2019

Basic support for readable and writeable streams (as discussed in #34 ).

Works fine for me but could probably do with some testing :)

@bwiercinski
Copy link

@fridjon great great job, please attach my PR fridjon#1

also why there is no SMB2Request('close',...) in this code, as it is in readfile.js

@bchelli

@nadimz
Copy link

nadimz commented Dec 10, 2020

@bchelli, any plan for this to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridjon @bwiercinski @nadimz