Add Menu component #517
Draft
Add Menu component #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Philip-Cheung I'd like to walk you through the WIP on this component and get your thoughts — I'll find some time this week for us to connect. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new Menu component, using RAC Menu as a foundation. It also implements Popover, which is used internally by Menu and Select.
Menu provides a method to implement a dropdown navigation menu. It is composed of several subcomponents that can be used as needed:
MenuTrigger: a wrapper component that enables a trigger element (like aButton) to activate a menuSubmenuTrigger: a secondary wrapper, which can be used internally withinMenuto create submenusMenu: the container component, which renders aPopoverand expects some number ofMenuItemcomponents as childrenMenuItem: used to create individual items within a dropdown menuMenuSectionandMenuSectionHeader: used to create sections within a menuDocs and examples are provided in Storybook. Leaving this PR in draft pending design review.