Skip to content

Conversation

@dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-2364

Changes

  • Allow for 0 as valid net book value on projects as per PO.
  • Change formatMoney function to display the cents if available.

Testing

Try to add/edit a project and have the Net Book field have a 0.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 3036. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@Sharala-Perumal
Copy link
Collaborator

On testing, its evident that Net book value is accepting $0 as a valid entry as shown below:
image
image
However, its not accepting blank values for Net book value as shown below. Is that acceptable? If so, I can progress the ticket to Approved. Plz confirm.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants