Skip to content

Conversation

@dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jul 28, 2025

🎯 Summary

PIMS-2347
Initial concern was that the Received On date field wasn't being saved.
In fixing this, I noticed two additional problems:

  1. If an agency is already in the response list but then becomes disabled, it's still possible to change its response to Subscribed.
  2. If an agency is already in the response list but then opts out of emails system-wide, it's still possible to change its response to Subscribed.

Changes

  • Now sending Received On date with the Agency Responses.
  • Backend logic that prevents agency responses from getting that Subscribed status if the agency is disabled, missing an email, or has opted out of emails.
  • Frontend UI changes for better viewing of agency responses.
  • Frontend styling to clearly display that an agency response cannot be changed to Subscribe and prevent the user from doing so.

Testing

  • Check that you can now save the Received On date
  • Check if you cannot set an agency response to Subscribed when it shouldn't be able to. AKA agency is disabled or opted out of emails.
  • Check that you can still subscribe and unsubscribe other agencies as expected.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@github-actions
Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 3027. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

@github-actions
Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 3027. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants