[CI only] upstream #7817: fix(pi): respect per-agent disabled state#41
Closed
bbingz wants to merge 3 commits into
Closed
[CI only] upstream #7817: fix(pi): respect per-agent disabled state#41bbingz wants to merge 3 commits into
bbingz wants to merge 3 commits into
Conversation
… extensions When `agentStatusHooksEnabled` was true, Orca would still install the managed `orca-*.ts` extension files into `~/.pi/agent/extensions` (and the OMP equivalent) even if the user had explicitly disabled the Pi agent in Settings > Agents. This happened because `buildPtyHostEnv` defaulted `piAgentKind` to "pi" for nearly all local PTY spawns (everything that was not OMP) and would unconditionally call `piTitlebarExtensionService.buildPtyEnv` as long as the global hooks flag was set. There was no check against the per-agent `disabledTuiAgents` list from user settings. We now guard both the Pi and OMP extension installation paths with `isTuiAgentEnabled(...)`, and forward `disabledTuiAgents` from settings in all three call sites of `buildPtyHostEnv`. Fixes stablyai#7814
Regression tests for stablyai#7814 / stablyai#7817: with global agent status hooks on, disabledTuiAgents must prevent managed orca-*.ts extension install into ~/.pi and ~/.omp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact-head CI verification for stablyai#7817. This PR is not intended to merge and will be closed after checks complete.