Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to include client expiration #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fieldofsheep
Copy link

Working on the last PR was too out of date with Merge Conflicts so I bedded in the changes. Linter must have cleaned some aspects of the file too. This encompasses #143

Copy link
Owner

@bbernhard bbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, completely forgot to review your changes!

A few things I've noticed:

  • I think it would be better to rename func (a *Api) Contact(c *gin.Context) to func (a *Api) UpdateContact(c *gin.Context) to make it clear that the function updates the contact information.

  • As the request only updates the contact info, I think it would be better to use PUT instead of POST.

  • At the moment (almost) all the endpoints use the plural form. So I think it would be better to change the endpoint to /v1/contacts instead of /v1/contact

  • The JSON-RPC implementation is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants