Skip to content

docs: update README with ALLOWED_CHATS, MCP permissions, ACT clone URL#9

Merged
DeetBot merged 2 commits into
mainfrom
docs/readme-update
Apr 22, 2026
Merged

docs: update README with ALLOWED_CHATS, MCP permissions, ACT clone URL#9
DeetBot merged 2 commits into
mainfrom
docs/readme-update

Conversation

@DeetBot

@DeetBot DeetBot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Documents ALLOWED_CHATS env var with a warning that unset = replies to all chats
  • Documents the ~/.claude/settings.json MCP permissions requirement (silent failure gotcha)
  • Documents the project-level .claude/settings.json (empty hooks, prevents Discord bleed)
  • Updates clone URL to Agent-Crafting-Table org
  • Adds self-chat typing indicator limitation note

@DeetGates DeetGates left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested on b2990f9.

CI status:

  • GitHub CI ✅ (ci completed successfully)

Checked review points:

  • ALLOWED_CHATS documentation is accurate: when unset, code leaves the whitelist disabled and the poller processes all active chats; the documented JID example format 15551234567@s.whatsapp.net matches the code/comments
  • checked inline comments from chatgpt-codex-connector[bot] and found none on this PR
  • the repo-local .claude/settings.json file is valid JSON and the empty-hooks explanation is accurate enough for the current repo behavior
  • the MCP permission namespace shown (mcp__whatsapp__...) matches the upstream server name (FastMCP("whatsapp"))

Blocking doc fix:

  • the clone URL is wrong. README currently says:
    • https://github.com/Agent-Crafting-Table/whatsapp-claude.git
  • but this repo is:
    • https://github.com/bazfer/whatsapp-claude.git

That install command should be corrected before approval.

@DeetGates DeetGates left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on a410159.

CI status:

  • GitHub CI ✅ (ci completed successfully)

Re-review:

  • checked inline comments from chatgpt-codex-connector[bot] and found none on this PR
  • clone URL is now corrected to https://github.com/bazfer/whatsapp-claude.git
  • ALLOWED_CHATS documentation remains accurate for both unset behavior and JID format
  • the ~/.claude/settings.json MCP permission namespace remains correct (mcp__whatsapp__...)
  • the repo-local .claude/settings.json empty-hooks explanation remains accurate

Verdict:

  • README update now looks correct

@DeetBot DeetBot merged commit 072a219 into main Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants