docs: update README with ALLOWED_CHATS, MCP permissions, ACT clone URL#9
Merged
Conversation
DeetGates
requested changes
Apr 22, 2026
DeetGates
left a comment
Collaborator
There was a problem hiding this comment.
Changes requested on b2990f9.
CI status:
- GitHub CI ✅ (
cicompleted successfully)
Checked review points:
ALLOWED_CHATSdocumentation is accurate: when unset, code leaves the whitelist disabled and the poller processes all active chats; the documented JID example format15551234567@s.whatsapp.netmatches the code/comments- checked inline comments from
chatgpt-codex-connector[bot]and found none on this PR - the repo-local
.claude/settings.jsonfile is valid JSON and the empty-hooks explanation is accurate enough for the current repo behavior - the MCP permission namespace shown (
mcp__whatsapp__...) matches the upstream server name (FastMCP("whatsapp"))
Blocking doc fix:
- the clone URL is wrong. README currently says:
https://github.com/Agent-Crafting-Table/whatsapp-claude.git
- but this repo is:
https://github.com/bazfer/whatsapp-claude.git
That install command should be corrected before approval.
DeetGates
approved these changes
Apr 22, 2026
DeetGates
left a comment
Collaborator
There was a problem hiding this comment.
Approved on a410159.
CI status:
- GitHub CI ✅ (
cicompleted successfully)
Re-review:
- checked inline comments from
chatgpt-codex-connector[bot]and found none on this PR - clone URL is now corrected to
https://github.com/bazfer/whatsapp-claude.git ALLOWED_CHATSdocumentation remains accurate for both unset behavior and JID format- the
~/.claude/settings.jsonMCP permission namespace remains correct (mcp__whatsapp__...) - the repo-local
.claude/settings.jsonempty-hooks explanation remains accurate
Verdict:
- README update now looks correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALLOWED_CHATSenv var with a warning that unset = replies to all chats~/.claude/settings.jsonMCP permissions requirement (silent failure gotcha).claude/settings.json(empty hooks, prevents Discord bleed)