Skip to content

Filter out non-standard header extensions from module maps #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dierksen wants to merge 1 commit into from
Closed

Filter out non-standard header extensions from module maps #912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift/internal/module_maps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def write_module_map(

def _add_headers(*, headers, kind):
content.add_all(
headers,
Copy link
Contributor

@jerrymarino jerrymarino Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ending up being called in rules_swift ? I'd expect this to not be called - I wonder if there's been a regression in rules_swift - or it's not conditionally flipped off

[h for h in headers if h.extension.lower() in ("h", "hpp", "hh")],
allow_closure = True,
format_each = ' {} "%s"'.format(kind),
map_each = _relativized_header_paths,
Expand Down