feat(clippy): Introduce flag to toggle transitive aspect #3612
Conversation
| >&2 echo " Output file: ${NEW_WORKSPACE}/bazel-bin/test/clippy/${2%_clippy}.clippy.out" | ||
| >&2 echo " Run \"bazel build //test/clippy:${2}\" to see the output" | ||
| >&2 echo " Run \"bazel build //test/clippy:${2} ${@:3}\" to see the output" | ||
|
|
There was a problem hiding this comment.
These two are drive-by changes, but I realized we should have the flags if we want to have an easy repro.
blorente
force-pushed
the
blorente/no_clippy_aspect
branch
2 times, most recently
from
64fbead to
0b56bbd
Compare
blorente
force-pushed
the
blorente/no_clippy_aspect
branch
from
0b56bbd to
32d58e3
Compare
|
This feels quite out of character from how I generally expect linters/analysers to work... My understanding is ASAN needs to be applied to deps because they actually need to be built in that mode for ASAN to work? Whereas it feels like it's really the job of the caller to decide which targets they want to run clippy for... Like, I'd expect folks to mostly be keeping HEAD clean, and either running clippy on We do at least set @UebelAndre do you have any thoughts here? |
A follow up to #3607 . This PR introduces a flag,
--@rules_rust//rust/settings:experimental_clippy_aspect_traverse_deps=True, that tells the clippy aspect that it should traverse thedepsedges of a target and collect its Clippy output and results.See
clippy_failure_tester.shfor effects before and after.I'm still not sure this change is wanted, but clippy is close enough to a static analyzer like asan that I think it would make sense to give folks the option to toggle this behaviour. I'm happy to close this PR, I just wanted to give an option to folks who want to use clippy like this.