Allow for deps with only CcInfo on framework imports #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dierksen
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins and
thii
as code owners
Contributor
Author
|
I'm also not completely sure, style-wise, if all the various combinations of providers make sense here, or if only the lone |
keith
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add some
swift_c_moduledeps for a framework import, and they don't currently work since that only providesCcInfoandSwiftInfo.It appears that all the uses for
apple_common.Objccheck to see if it exists, so that shouldn't be a hard requirement at this point. That said, we also would need to cherry-pick this onto 5.x, and the existence check would need to be added along with this change: https://github.com/bazelbuild/rules_apple/compare/bazel/5.x...dierksen:rules_apple:objc_provider_check?expand=1