Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing rules_scala to custom bzlmod-compatible version and removing WORKSPACE #7281

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

sellophane
Copy link
Collaborator

@sellophane sellophane commented Feb 5, 2025

To achieve Bazel 9+ compatiblity, we need to stop using WORKSPACE file, as --enable_workspace will be no longer available (it is already no-op in Bazel@HEAD). Regular bazelbuild/rules_scala are still not bzlmod-compatible, so we need to switch to and experimental custom ones from https://github.com/mbland/rules_scala/

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #7232

Description of this change

@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Feb 5, 2025
@ujohnny
Copy link
Collaborator

ujohnny commented Feb 5, 2025

looks great, have you checked it with last_green?

@sellophane
Copy link
Collaborator Author

looks great, have you checked it with last_green?

yes, it looks like it's working

Copy link
Collaborator

@agluszak agluszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is maven_install.json removed?

@ujohnny
Copy link
Collaborator

ujohnny commented Feb 6, 2025

Why is maven_install.json removed?

@agluszak I guess it's not, it's just repinned with -800 lines

@agluszak
Copy link
Collaborator

agluszak commented Feb 6, 2025

Why is maven_install.json removed?

@agluszak I guess it's not, it's just repinned with -800 lines

ahh, yes, I looked at the wrong file 🤦

@ujohnny ujohnny merged commit 5396d52 into bazelbuild:master Feb 7, 2025
5 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants