Add a flag to specify the JDK version to package with Bazel when building the container image #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lruellan
requested review from
fweikert,
meteorcloudy and
Wyverald
as code owners
| @@ -21,6 +23,10 @@ if [ -z "${BAZEL_VERSION}" ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [ -z "$JAVA_VERSION" ]; then | |||
| JAVA_VERSION="openjdk-8-jdk" | |||
There was a problem hiding this comment.
I think there is no hurt to upgrade the default JDK version to 11 or even 21?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build script includes the Java 8 JDK but rules_jvm_external extension requires Java 11 (https://github.com/bazel-contrib/rules_jvm_external/releases/tag/6.7).