Skip to content

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Oct 19, 2025

Merkle tree computations and uploads should not continue after a build has been interrupted.

Merkle tree computations and uploads should not continue after a build has been interrupted.
@fmeum fmeum marked this pull request as ready for review October 19, 2025 21:59
@fmeum fmeum requested a review from a team as a code owner October 19, 2025 21:59
@fmeum fmeum requested a review from tjgq October 19, 2025 21:59
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Oct 19, 2025
@fmeum fmeum requested a review from Copilot October 19, 2025 21:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds interrupt handling to the MerkleTreeComputer class to properly cancel ongoing futures when a build is interrupted. This ensures that merkle tree computations and uploads don't continue unnecessarily after interruption signals are received.

  • Added interrupt exception handling to cancel futures on interrupts
  • Ensures proper cleanup of running futures when builds are cancelled

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 20, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants