[8.5.0] Add a createSymbolicLink argument indicating the file type of the target. #27314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Remote-Exec
tjgq
force-pushed
the
8.5.0-symlink-type
branch
3 times, most recently
from
d702136 to
1793820
Compare
… the target. On Windows, a different kind of filesystem object (junction or symlink) needs to be created depending on the target type, which is not always inspectable in "building without the bytes" scenarios where the symlink is created ahead of its target. This CL only introduces the formal argument and adjusts the WindowsFileSystem#createSymbolicLink implementation accordingly. A followup CL will pass in the argument where required. Progress on bazelbuild#21747 and bazelbuild#26701. PiperOrigin-RevId: 802504976 Change-Id: I912a84ba6734bf0562f369c7659bcc25f259e70f
tjgq
force-pushed
the
8.5.0-symlink-type
branch
from
1793820 to
19a51a0
Compare
|
#27323 must be submitted first, then it should be fine to come back to this one. |
iancha1992
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, a different kind of filesystem object (junction or symlink) needs to be created depending on the target type, which is not always inspectable in "building without the bytes" scenarios where the symlink is created ahead of its target.
This CL only introduces the formal argument and adjusts the WindowsFileSystem#createSymbolicLink implementation accordingly. A followup CL will pass in the argument where required.
Progress on #21747 and #26701.
PiperOrigin-RevId: 802504976
Change-Id: I912a84ba6734bf0562f369c7659bcc25f259e70f