Skip to content

Enable more HTTP decompression methods for remote cache #27271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable more HTTP decompression methods for remote cache #27271

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2891bf
Enable more HTTP decompression methods for remote cache
AlexanderGolovlev Oct 14, 2025
7603fc3
Extracted into static helper function
AlexanderGolovlev Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/main/java/com/google/devtools/build/lib/remote/http/HttpDownloadHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelPromise;
import io.netty.handler.codec.compression.Brotli;
import io.netty.handler.codec.compression.Zstd;
import io.netty.handler.codec.http.DefaultFullHttpRequest;
import io.netty.handler.codec.http.HttpContent;
import io.netty.handler.codec.http.HttpHeaderNames;
Expand All @@ -42,6 +44,19 @@
/** ChannelHandler for downloads. */
final class HttpDownloadHandler extends AbstractHttpHandler<HttpObject> {

private static final String ACCEPT_ENCODING;
static {
StringBuilder acceptEncoding = new StringBuilder(HttpHeaderValues.GZIP);
acceptEncoding.append(",").append(HttpHeaderValues.DEFLATE).append(",").append(HttpHeaderValues.SNAPPY);
if (Brotli.isAvailable()) {
acceptEncoding.append(",").append(HttpHeaderValues.BR);
}
if (Zstd.isAvailable()) {
acceptEncoding.append(",").append(HttpHeaderValues.ZSTD);
}
ACCEPT_ENCODING = acceptEncoding.toString();
}

private OutputStream out;
private boolean keepAlive = HttpVersion.HTTP_1_1.isKeepAliveDefault();
private boolean downloadSucceeded;
Expand Down Expand Up @@ -180,7 +195,7 @@ private HttpRequest buildRequest(String path, String host) {
httpRequest.headers().set(HttpHeaderNames.HOST, host);
httpRequest.headers().set(HttpHeaderNames.CONNECTION, HttpHeaderValues.KEEP_ALIVE);
httpRequest.headers().set(HttpHeaderNames.ACCEPT, "*/*");
httpRequest.headers().set(HttpHeaderNames.ACCEPT_ENCODING, HttpHeaderValues.GZIP);
httpRequest.headers().set(HttpHeaderNames.ACCEPT_ENCODING, ACCEPT_ENCODING);
return httpRequest;
}

Expand Down