Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BUILD.bazel before symlinking when creating new_local_repository #24887

Closed
wants to merge 1 commit into from

Conversation

davexroth
Copy link
Contributor

Fixes #24770

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 9, 2025
@Wyverald Wyverald added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 9, 2025
@fmeum
Copy link
Collaborator

fmeum commented Jan 10, 2025

@bazel-io fork 7.5.0

@fmeum
Copy link
Collaborator

fmeum commented Jan 10, 2025

@bazel-io fork 8.0.1

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 10, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 10, 2025
Fixes bazelbuild#24770

Closes bazelbuild#24887.

PiperOrigin-RevId: 714107497
Change-Id: Ib914aa54b2afa2a90fcce2f2263b9c1b2d2c193c
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 10, 2025
Fixes bazelbuild#24770

Closes bazelbuild#24887.

PiperOrigin-RevId: 714107497
Change-Id: Ib914aa54b2afa2a90fcce2f2263b9c1b2d2c193c
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
…repository (#24901)

Fixes #24770

Closes #24887.

PiperOrigin-RevId: 714107497
Change-Id: Ib914aa54b2afa2a90fcce2f2263b9c1b2d2c193c

Commit
6a141ea

Co-authored-by: Dave Roth <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2025
…repository (#24900)

Fixes #24770

Closes #24887.

PiperOrigin-RevId: 714107497
Change-Id: Ib914aa54b2afa2a90fcce2f2263b9c1b2d2c193c

Commit
6a141ea

Co-authored-by: Dave Roth <[email protected]>
meteorcloudy pushed a commit that referenced this pull request Jan 14, 2025
…repository (#24900)

Fixes #24770

Closes #24887.

PiperOrigin-RevId: 714107497
Change-Id: Ib914aa54b2afa2a90fcce2f2263b9c1b2d2c193c

Commit
6a141ea

Co-authored-by: Dave Roth <[email protected]>
fmeum pushed a commit to fmeum/bazel that referenced this pull request Jan 14, 2025
Fixes bazelbuild#24770

Closes bazelbuild#24887.

PiperOrigin-RevId: 714107497
Change-Id: Ib914aa54b2afa2a90fcce2f2263b9c1b2d2c193c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new_local_repository fails when repo contains a BUILD file
3 participants