Update libxtrans dep in libx11 and bump libx11 to 1.8.12.bcr.3 #6253
Conversation
|
Hello @wep21, modules you maintain (libx11) have been updated in this PR. |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates libx11 to version 1.8.12.bcr.3 and its libxtrans dependency to fix a compilation error on Ubuntu 24.04. The changes are generally good, but I have identified a critical issue in a configuration template that would cause the build to fail, and a high-severity issue related to version parsing that could cause problems in the future. Please see my detailed comments.
Signed-off-by: Shameek Ganguly <[email protected]>
|
The presubmit failures seem to be infra related: https://buildkite.com/bazel/bcr-presubmit/builds/21504/steps/canvas?jid=019a02a7-4faa-4e91-a973-cdf38153f7ac#019a02a7-4faa-4e91-a973-cdf38153f7ac/74-77 |
|
@shameekganguly #6233 has same change. Is it okay to close this one? |
Perfect, thank you @wep21! |
3 participants
libxtransdep updated to 1.5.2.bcr.2 to pull in fix for compilation error on Ubuntu 24.04.Also fix one error in config.h.in (see review comment).