Skip to content

Simple upgrades to Bzlmod migration tool #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2025
Merged

Simple upgrades to Bzlmod migration tool #6251

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
948abb5
Simple upgrades to Bzlmod migration toon
kotlaja Oct 20, 2025
e860b14
address comments
kotlaja Oct 21, 2025
542ff60
format
kotlaja Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions tools/migrate_to_bzlmod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,10 @@ def add_python_extension(repo, origin_attrs, resolved_deps, workspace_name):
important(f"Using existing default python version {python_version} from MODULE.bazel.")
else:
important(
f"{python_version} is used as a default python version. If you need a different version, please change it manually and then rerun the migration tool."
f"""{python_version} is used as a default python version.
If you need a different version, please change it manually and then rerun the migration tool.
If you're using `python_register_multi_toolchains`, add `python.toolchain` for each python version.
"""
)

py_ext = f"""
Expand Down Expand Up @@ -583,20 +586,6 @@ def add_python_extension(repo, origin_attrs, resolved_deps, workspace_name):
append_migration_info("```" + py_ext + "\n" + py_toolchain_msg + "\n```")


def add_python_repo(repo):
append_migration_info("## Migration of `" + repo + "`")
append_migration_info("It has been introduced as a python repo:\n")

py_repo = f'use_repo(python, "{repo}")'
write_at_given_place(
"MODULE.bazel",
py_repo,
"# -- End of pip extensions -- #",
)
resolved("`" + repo + "` has been introduced as a python repo.")
append_migration_info("```\n" + py_repo + "\n```")


def address_unavailable_repo(repo, resolved_deps, workspace_name):
# Check if it's the original main repo name
if repo == workspace_name:
Expand Down Expand Up @@ -794,7 +783,7 @@ def prepare_migration(initial_flag):
workspace_name = "main"
with open("WORKSPACE", "r") as f:
for line in f:
s = re.search(r"workspace\(name\s+=\s+[\'\"]([A-Za-z0-9_-]+)[\'\"]", line)
s = re.search(r"workspace\(name\s*=\s*[\'\"]([A-Za-z0-9_-]+)[\'\"]", line)
if s:
workspace_name = s.groups()[0]
info(f"Detected original workspace name: {workspace_name}\n")
Expand Down
Loading