Skip to content

Add [email protected] #6217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

Add [email protected] #6217

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c6f286
Add [email protected]
bstoll Oct 15, 2025
64c4680
Update presubmit build flags & incompatible flags
bstoll Oct 16, 2025
276d292
Remove incompatible flags.
bstoll Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions modules/openconfig_attestz/0.6.0/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module(
name = "openconfig_attestz",
version = "0.6.0",
)

bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle")
bazel_dep(name = "grpc", version = "1.74.1", repo_name = "com_github_grpc_grpc")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This bazel_dep on grpc (the C++ library) appears to be unused for this Go module. The necessary Go gRPC dependencies are fetched via go_deps from go.mod, and rules_go utilizes the Go gRPC protoc plugin from those dependencies. Removing this unused dependency will simplify the dependency graph for consumers of this module.

bazel_dep(name = "protobuf", version = "32.1", repo_name = "com_google_protobuf")
bazel_dep(name = "rules_go", version = "0.57.0", repo_name = "io_bazel_rules_go")
bazel_dep(name = "rules_proto", version = "7.1.0")

go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(version = "1.25.1")

go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//:go.mod")
use_repo(go_deps, "com_github_golang_glog", "com_github_google_go_cmp", "org_golang_google_grpc", "org_golang_google_grpc_cmd_protoc_gen_go_grpc", "org_golang_google_protobuf", "com_github_google_go_tpm")
10 changes: 10 additions & 0 deletions modules/openconfig_attestz/0.6.0/patches/module_dot_bazel.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--- MODULE.bazel
+++ MODULE.bazel
@@ -1,6 +1,6 @@
module(
name = "openconfig_attestz",
- version = "0.0.0",
+ version = "0.6.0",
)

bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle")
Comment on lines +1 to +10
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This patch attempts to modify a MODULE.bazel file, but this file does not exist in the upstream source archive for tag v0.6.0. This will cause the patch to fail during presubmit checks. The patch should instead be written to create the MODULE.bazel file.

I have also taken the liberty of removing the seemingly unused bazel_dep on grpc from the suggested patch content below.

--- /dev/null
+++ MODULE.bazel
@@ -0,0 +1,16 @@
+module(
+    name = "openconfig_attestz",
+    version = "0.6.0",
+)
+
+bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle")
+bazel_dep(name = "protobuf", version = "32.1", repo_name = "com_google_protobuf")
+bazel_dep(name = "rules_go", version = "0.57.0", repo_name = "io_bazel_rules_go")
+bazel_dep(name = "rules_proto", version = "7.1.0")
+
+go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
+go_sdk.download(version = "1.25.1")
+
+go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps")
+go_deps.from_file(go_mod = "//:go.mod")
+use_repo(go_deps, "com_github_golang_glog", "com_github_google_go_cmp", "org_golang_google_grpc", "org_golang_google_grpc_cmd_protoc_gen_go_grpc", "org_golang_google_protobuf", "com_github_google_go_tpm")

14 changes: 14 additions & 0 deletions modules/openconfig_attestz/0.6.0/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
matrix:
platform:
- debian10
- ubuntu2004
bazel:
- 8.x
- 7.x
tasks:
verify_targets:
name: Verify build targets
platform: ${{ platform }}
bazel: ${{ bazel }}
build_targets:
- '@openconfig_attestz//...'
9 changes: 9 additions & 0 deletions modules/openconfig_attestz/0.6.0/source.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"url": "https://github.com/openconfig/attestz/archive/refs/tags/v0.6.0.tar.gz",
"integrity": "sha256-vyYwtH/64xn954LFOeu4FUZWqFtYDDZVliwpXQeKhpY=",
"strip_prefix": "attestz-0.6.0",
"patch_strip": 0,
"patches": {
"module_dot_bazel.patch": "sha256-P3Me+JnnfZTCBevBvEg7iVHjyXyVd2uW8WNbBxIQoEo="
}
}
3 changes: 2 additions & 1 deletion modules/openconfig_attestz/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"github:openconfig/attestz"
],
"versions": [
"0.5.0"
"0.5.0",
"0.6.0"
],
"yanked_versions": {}
}
Loading