Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #1735

Closed
wants to merge 1 commit into from
Closed

[email protected] #1735

wants to merge 1 commit into from

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

luispadron
luispadron previously approved these changes Apr 1, 2024
View reviewed changes
@bazel-io bazel-io dismissed luispadron’s stale review April 1, 2024 17:38

Require module maintainers' approval for newly pushed changes.

@bazel-io
Copy link
Member

bazel-io commented Apr 1, 2024

Hello @keith, @BalestraPatrick, modules you maintain (apple_support) have been updated in this PR. Please review the changes.

@keith keith enabled auto-merge (squash) April 1, 2024 17:38
bazel-io
bazel-io approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@keith
Copy link
Member

keith commented Apr 1, 2024

something failed here, probably not expected and just something we should exclude from the BCR tests

@luispadron luispadron mentioned this pull request Apr 1, 2024
Closed
@luispadron
Copy link
Contributor

@keith i opened bazelbuild/apple_support#319 but not sure how to update this BCR fork

@brentleyjones
Copy link
Contributor

I don't understand the failure. Works on 6.x, 8.x, and locally.

@brentleyjones
Copy link
Contributor

I repro'ed in by calling the test from an external repo, which is what the tests do.

@brentleyjones
Copy link
Contributor

Bug with gcc_quoting_for_param_files. Looking into it.

@brentleyjones
Copy link
Contributor

A valid bug, going to close. We will have a 1.15.1 release.

auto-merge was automatically disabled April 1, 2024 19:25

Pull request was closed

@brentleyjones brentleyjones deleted the bazelbuild/[email protected] branch April 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@luispadron luispadron luispadron approved these changes

@bazel-io bazel-io bazel-io approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bazel-io @keith @luispadron @brentleyjones @BalestraPatrick