Mark module extension as reproducible #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
fmeum
commented
May 16, 2024
fmeum
force-pushed
the
reproducible
branch
4 times, most recently
from
015760e to
8ab815b
Compare
MODULE.bazel
Outdated
| @@ -17,7 +17,7 @@ bazel_dep( | |||
| repo_name = "io_bazel_stardoc", | |||
| ) | |||
|
|
|||
| apple_cc_configure = use_extension("//crosstool:setup.bzl", "apple_cc_configure_extension") | |||
| apple_cc_configure = use_extension("//crosstool:apple_cc_configure_extension.bzl", "apple_cc_configure_extension") | |||
There was a problem hiding this comment.
Is this file rename a breaking change for users? We have a blurb in the README that references the old name.
There was a problem hiding this comment.
It would be, yes. I think it's better to wait for apple_support to drop Bazel 5 support and then land this commit without the need for this breaking change.
crosstool/internal/BUILD.bazel
Outdated
There was a problem hiding this comment.
In this repo we use BUILD instead of BUILD.bazel if possible.
|
Is this closer to getting merged ? I'm closing my quest of having the cleanest lockfile possible ! |
luispadron
approved these changes
Feb 6, 2025
luispadron
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an unnecessary lockfile entry.
The module extension is kept in place so that
use_extensioncalls don't need to be updated. The repo rules are moved into a separate file so that WORKSPACE setups don't fail on a cyclic load ofbazel_features. The newly exposed repo rules are protected by load visibility.