Skip to content

Mark non_module_deps as reproducible #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ssaradp wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Mark non_module_deps as reproducible #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b57ba9
Mark non_module_deps as reproducible
ssaradp Jan 30, 2025
8840f89
Revert test change
ssaradp Jan 30, 2025
7d39f00
Buildifier fix
ssaradp Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ bazel_dep(
name = "bazel_skylib",
version = "1.4.2",
)
bazel_dep(
name = "bazel_features",
version = "1.9.0",
)

# Declare the development dependencies needed for rules_ios development
bazel_dep(
Expand Down
10 changes: 9 additions & 1 deletion rules/module_extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@ load(
"//tools/toolchains/xcode_configure:xcode_configure.bzl",
_xcode_configure = "xcode_configure",
)
load("@bazel_features//:features.bzl", "bazel_features")

def _non_module_deps_impl(_):
def _non_module_deps_impl(module_ctx):
rules_ios_dependencies(
load_bzlmod_dependencies = False,
)
metadata_kwargs = {}
if bazel_features.external_deps.extension_metadata_has_reproducible:
metadata_kwargs["reproducible"] = True

return module_ctx.extension_metadata(
**metadata_kwargs
)

non_module_deps = module_extension(implementation = _non_module_deps_impl)

Expand Down